fix: We were applying the max_sites_to_claim filter too early. Many s…#422
Merged
adam-miller merged 2 commits intomasterfrom Nov 13, 2025
Merged
fix: We were applying the max_sites_to_claim filter too early. Many s…#422adam-miller merged 2 commits intomasterfrom
adam-miller merged 2 commits intomasterfrom
Conversation
…ites in a single crawl prevent claimable sites from getting through.
mistydemeo
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ites in a single crawl prevent claimable sites from getting through.
Added a unit test for this situation. When we have lots of sites in a single job and all get claimed, this fills the
claimable_siteslist with only sites that will end up being excluded due to the job max being hit. We need to pass along all of the claimable sites to let other jobs get through. The added test triggers this bug, and only passes with the changes tofrontier.py